Commit 25cf87df authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Thomas Gleixner
Browse files

net: sundance: Use tasklet_disable_in_atomic(). 



tasklet_disable() is used in the timer callback. This might be distangled,
but without access to the hardware that's a bit risky.

Replace it with tasklet_disable_in_atomic() so tasklet_disable() can be
changed to a sleep wait once all remaining atomic users are converted.

Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210309084242.209110861@linutronix.de
parent c62c38e3

drivers/net/ethernet/dlink/sundance.c

+1 −1
Original line number Diff line number Diff line
@@ -963,7 +963,7 @@ static void tx_timeout(struct net_device *dev, unsigned int txqueue) 
	unsigned long flag;



	netif_stop_queue(dev);

	tasklet_disable(&np->tx_tasklet);

	tasklet_disable_in_atomic(&np->tx_tasklet);

	iowrite16(0, ioaddr + IntrEnable);

	printk(KERN_WARNING "%s: Transmit timed out, TxStatus %2.2x "

		   "TxFrameId %2.2x,"