Commit 25978642 authored by Aya Mahfouz's avatar Aya Mahfouz Committed by Greg Kroah-Hartman
Browse files

staging: rtl8712: remove extra parentheses around right bit shift operation 



Removes extra parentheses around bitwise right shift operation.
The cases handled are  when the resultant value is assigned to
a variable or when a shift operation is carried out for a function
argument. The issues were detected and resolved using the following
coccinelle script:

@@
expression e, e1;
constant c;
@@

e =
-(e1
+e1
>>
-c);
+c;

@@
identifier i;
constant c;
type t;
expression e;
@@

t i =
-(e
+e
>>
-c);
+c;

@@
expression e, e1;
identifier f;
constant c;
@@

e1 = f(...,
-(e
+e
>>
-c)
+c
,...);

Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9eb9e695

drivers/staging/rtl8712/rtl8712_recv.c

+2 −2
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static void update_recvframe_attrib_from_recvstat(struct rx_pkt_attrib *pattrib, 
	 * Offset 0 */

	pattrib->bdecrypted = ((le32_to_cpu(prxstat->rxdw0) & BIT(27)) >> 27)

				 ? 0 : 1;

	pattrib->crc_err = ((le32_to_cpu(prxstat->rxdw0) & BIT(14)) >> 14);

	pattrib->crc_err = (le32_to_cpu(prxstat->rxdw0) & BIT(14)) >> 14;

	/*Offset 4*/

	/*Offset 8*/

	/*Offset 12*/
@@ -435,7 +435,7 @@ void r8712_rxcmd_event_hdl(struct _adapter *padapter, void *prxcmdbuf) 
	poffset = (u8 *)prxcmdbuf;

	voffset = *(uint *)poffset;

	prxstat = (struct recv_stat *)prxcmdbuf;

	drvinfo_sz = ((le32_to_cpu(prxstat->rxdw0) & 0x000f0000) >> 16);

	drvinfo_sz = (le32_to_cpu(prxstat->rxdw0) & 0x000f0000) >> 16;

	drvinfo_sz <<= 3;

	poffset += RXDESC_SIZE + drvinfo_sz;

	do {

drivers/staging/rtl8712/rtl871x_mp.c

+2 −2
Original line number Diff line number Diff line
@@ -327,8 +327,8 @@ void r8712_SetTxAGCOffset(struct _adapter *pAdapter, u32 ulTxAGCOffset) 
	u32 TxAGCOffset_B, TxAGCOffset_C, TxAGCOffset_D, tmpAGC;



	TxAGCOffset_B = (ulTxAGCOffset&0x000000ff);

	TxAGCOffset_C = ((ulTxAGCOffset&0x0000ff00)>>8);

	TxAGCOffset_D = ((ulTxAGCOffset&0x00ff0000)>>16);

	TxAGCOffset_C = (ulTxAGCOffset & 0x0000ff00)>>8;

	TxAGCOffset_D = (ulTxAGCOffset & 0x00ff0000)>>16;

	tmpAGC = (TxAGCOffset_D<<8 | TxAGCOffset_C<<4 | TxAGCOffset_B);

	set_bb_reg(pAdapter, rFPGA0_TxGainStage,

			(bXBTxAGC|bXCTxAGC|bXDTxAGC), tmpAGC);