Commit 241887a2 authored by Johannes Berg's avatar Johannes Berg Committed by Wey-Yi Guy
Browse files

iwlwifi: fix beacon notification parsing 



The beacon notification changed between 4965 and
agn because the embedded TX response changed, but
iwlwifi was never updated to know about this.
Update it now so the IBSS manager status will be
tracked correctly.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
parent 7b090687

drivers/net/wireless/iwlwifi/iwl-4965.c

+24 −0
Original line number Diff line number Diff line
@@ -2266,6 +2266,29 @@ static void iwl4965_rx_reply_tx(struct iwl_priv *priv, 
	spin_unlock_irqrestore(&priv->sta_lock, flags);

}



static void iwl4965_rx_beacon_notif(struct iwl_priv *priv,

				    struct iwl_rx_mem_buffer *rxb)

{

	struct iwl_rx_packet *pkt = rxb_addr(rxb);

	struct iwl4965_beacon_notif *beacon = (void *)pkt->u.raw;

#ifdef CONFIG_IWLWIFI_DEBUG

	u8 rate = iwl_hw_get_rate(beacon->beacon_notify_hdr.rate_n_flags);



	IWL_DEBUG_RX(priv, "beacon status %#x, retries:%d ibssmgr:%d "

		"tsf:0x%.8x%.8x rate:%d\n",

		le32_to_cpu(beacon->beacon_notify_hdr.u.status) & TX_STATUS_MSK,

		beacon->beacon_notify_hdr.failure_frame,

		le32_to_cpu(beacon->ibss_mgr_status),

		le32_to_cpu(beacon->high_tsf),

		le32_to_cpu(beacon->low_tsf), rate);

#endif



	priv->ibss_manager = le32_to_cpu(beacon->ibss_mgr_status);



	if (!test_bit(STATUS_EXIT_PENDING, &priv->status))

		queue_work(priv->workqueue, &priv->beacon_update);

}



static int iwl4965_calc_rssi(struct iwl_priv *priv,

			     struct iwl_rx_phy_res *rx_resp)

{
@@ -2308,6 +2331,7 @@ static void iwl4965_rx_handler_setup(struct iwl_priv *priv) 
	priv->rx_handlers[REPLY_RX] = iwlagn_rx_reply_rx;

	/* Tx response */

	priv->rx_handlers[REPLY_TX] = iwl4965_rx_reply_tx;

	priv->rx_handlers[BEACON_NOTIFICATION] = iwl4965_rx_beacon_notif;



	/* set up notification wait support */

	spin_lock_init(&priv->_agn.notif_wait_lock);

drivers/net/wireless/iwlwifi/iwl-agn.c

+8 −8
Original line number Diff line number Diff line
@@ -704,18 +704,18 @@ static void iwl_bg_ucode_trace(unsigned long data) 
	}

}



static void iwl_rx_beacon_notif(struct iwl_priv *priv,

static void iwlagn_rx_beacon_notif(struct iwl_priv *priv,

				   struct iwl_rx_mem_buffer *rxb)

{

	struct iwl_rx_packet *pkt = rxb_addr(rxb);

	struct iwl4965_beacon_notif *beacon =

		(struct iwl4965_beacon_notif *)pkt->u.raw;

	struct iwlagn_beacon_notif *beacon = (void *)pkt->u.raw;

#ifdef CONFIG_IWLWIFI_DEBUG

	u16 status = le16_to_cpu(beacon->beacon_notify_hdr.status.status);

	u8 rate = iwl_hw_get_rate(beacon->beacon_notify_hdr.rate_n_flags);



	IWL_DEBUG_RX(priv, "beacon status %x retries %d iss %d "

		"tsf %d %d rate %d\n",

		le32_to_cpu(beacon->beacon_notify_hdr.u.status) & TX_STATUS_MSK,

	IWL_DEBUG_RX(priv, "beacon status %#x, retries:%d ibssmgr:%d "

		"tsf:0x%.8x%.8x rate:%d\n",

		status & TX_STATUS_MSK,

		beacon->beacon_notify_hdr.failure_frame,

		le32_to_cpu(beacon->ibss_mgr_status),

		le32_to_cpu(beacon->high_tsf),
@@ -818,7 +818,7 @@ static void iwl_setup_rx_handlers(struct iwl_priv *priv) 
	priv->rx_handlers[PM_SLEEP_NOTIFICATION] = iwl_rx_pm_sleep_notif;

	priv->rx_handlers[PM_DEBUG_STATISTIC_NOTIFIC] =

	    iwl_rx_pm_debug_statistics_notif;

	priv->rx_handlers[BEACON_NOTIFICATION] = iwl_rx_beacon_notif;

	priv->rx_handlers[BEACON_NOTIFICATION] = iwlagn_rx_beacon_notif;



	/*

	 * The same handler is used for both the REPLY to a discrete

drivers/net/wireless/iwlwifi/iwl-commands.h

+7 −0
Original line number Diff line number Diff line
@@ -3083,6 +3083,13 @@ struct iwl4965_beacon_notif { 
	__le32 ibss_mgr_status;

} __packed;



struct iwlagn_beacon_notif {

	struct iwlagn_tx_resp beacon_notify_hdr;

	__le32 low_tsf;

	__le32 high_tsf;

	__le32 ibss_mgr_status;

} __packed;



/*

 * REPLY_TX_BEACON = 0x91 (command, has simple generic response)

 */