Commit 23118b09 authored by Eugenio Pérez's avatar Eugenio Pérez Committed by Michael S. Tsirkin
Browse files

vdpa: Avoid duplicate call to vp_vdpa get_status 



It has no sense to call get_status twice, since we already have a
variable for that.

Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
Link: https://lore.kernel.org/r/20211104195833.2089796-1-eperezma@redhat.com


Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
parent 10aa250b

drivers/vhost/vdpa.c

+1 −1
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp) 
	 * Userspace shouldn't remove status bits unless reset the

	 * status to 0.

	 */

	if (status != 0 && (ops->get_status(vdpa) & ~status) != 0)

	if (status != 0 && (status_old & ~status) != 0)

		return -EINVAL;



	if ((status_old & VIRTIO_CONFIG_S_DRIVER_OK) && !(status & VIRTIO_CONFIG_S_DRIVER_OK))