Commit 21c2e341 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: Remove the TRUE and FALSE definitions 

In the Linux kernel coding style document
(Documentation/process/coding-style.rst) it is recommended to use the type
'bool' and also the values 'true' and 'false'. Hence this patch that
removes the definitions and uses of TRUE and FALSE from the UFS driver.

Link: https://lore.kernel.org/r/20220419225811.4127248-20-bvanassche@acm.org


Tested-by: default avatarBean Huo <beanhuo@micron.com>
Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Reviewed-by: default avatarBean Huo <beanhuo@micron.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d0c1725b

drivers/scsi/ufs/ufs-exynos.c

+2 −2
Original line number Diff line number Diff line
@@ -704,7 +704,7 @@ static void exynos_ufs_establish_connt(struct exynos_ufs *ufs) 


	/* local unipro attributes */

	ufshcd_dme_set(hba, UIC_ARG_MIB(N_DEVICEID), DEV_ID);

	ufshcd_dme_set(hba, UIC_ARG_MIB(N_DEVICEID_VALID), TRUE);

	ufshcd_dme_set(hba, UIC_ARG_MIB(N_DEVICEID_VALID), true);

	ufshcd_dme_set(hba, UIC_ARG_MIB(T_PEERDEVICEID), PEER_DEV_ID);

	ufshcd_dme_set(hba, UIC_ARG_MIB(T_PEERCPORTID), PEER_CPORT_ID);

	ufshcd_dme_set(hba, UIC_ARG_MIB(T_CPORTFLAGS), CPORT_DEF_FLAGS);
@@ -1028,7 +1028,7 @@ static int exynos_ufs_post_link(struct ufs_hba *hba) 


	if (ufs->opts & EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB)

		ufshcd_dme_set(hba,

			UIC_ARG_MIB(T_DBG_SKIP_INIT_HIBERN8_EXIT), TRUE);

			UIC_ARG_MIB(T_DBG_SKIP_INIT_HIBERN8_EXIT), true);



	if (attr->pa_granularity) {

		exynos_ufs_enable_dbg_mode(hba);

drivers/scsi/ufs/ufs-exynos.h

+4 −4
Original line number Diff line number Diff line
@@ -248,22 +248,22 @@ long exynos_ufs_calc_time_cntr(struct exynos_ufs *, long); 


static inline void exynos_ufs_enable_ov_tm(struct ufs_hba *hba)

{

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_OV_TM), TRUE);

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_OV_TM), true);

}



static inline void exynos_ufs_disable_ov_tm(struct ufs_hba *hba)

{

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_OV_TM), FALSE);

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_OV_TM), false);

}



static inline void exynos_ufs_enable_dbg_mode(struct ufs_hba *hba)

{

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_MODE), TRUE);

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_MODE), true);

}



static inline void exynos_ufs_disable_dbg_mode(struct ufs_hba *hba)

{

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_MODE), FALSE);

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_MODE), false);

}



#endif /* _UFS_EXYNOS_H_ */

drivers/scsi/ufs/ufshcd.c

+4 −4
Original line number Diff line number Diff line
@@ -4325,18 +4325,18 @@ static int ufshcd_change_power_mode(struct ufs_hba *hba, 
			pwr_mode->lane_rx);

	if (pwr_mode->pwr_rx == FASTAUTO_MODE ||

			pwr_mode->pwr_rx == FAST_MODE)

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_RXTERMINATION), TRUE);

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_RXTERMINATION), true);

	else

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_RXTERMINATION), FALSE);

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_RXTERMINATION), false);



	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXGEAR), pwr_mode->gear_tx);

	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_ACTIVETXDATALANES),

			pwr_mode->lane_tx);

	if (pwr_mode->pwr_tx == FASTAUTO_MODE ||

			pwr_mode->pwr_tx == FAST_MODE)

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXTERMINATION), TRUE);

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXTERMINATION), true);

	else

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXTERMINATION), FALSE);

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXTERMINATION), false);



	if (pwr_mode->pwr_rx == FASTAUTO_MODE ||

	    pwr_mode->pwr_tx == FASTAUTO_MODE ||

drivers/scsi/ufs/unipro.h

+0 −14
Original line number Diff line number Diff line
@@ -298,20 +298,6 @@ enum ufs_unipro_ver { 
#define T_TC0TXMAXSDUSIZE	0x4060

#define T_TC1TXMAXSDUSIZE	0x4061



#ifdef FALSE

#undef FALSE

#endif



#ifdef TRUE

#undef TRUE

#endif



/* Boolean attribute values */

enum {

	FALSE = 0,

	TRUE,

};



/* CPort setting */

#define E2EFC_ON	(1 << 0)

#define E2EFC_OFF	(0 << 0)