Commit 20dde50f authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

misc: sgi-gru: Don't cast parameter in bit operations 



While in this particular case (*) it would not be an issue,
the pattern itself is bad and error prone in case somebody
blindly copies to their code.

Don't cast parameter to unsigned long pointer in the bit
operations. Note, new compilers might warn on this line for
potential outbound access.

*) it seems a dead code, so remove it all for good

Fixes: 13d19498 ("GRU Driver: driver internal header files")
Acked-by: default avatarDimitri Sivanich <sivanich@hpe.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220214153958.9721-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 22f01029

drivers/misc/sgi-gru/grutables.h

+0 −6
Original line number Diff line number Diff line
@@ -530,12 +530,6 @@ struct gru_blade_state { 
		for ((i) = (k)*GRU_CBR_AU_SIZE;				\

				(i) < ((k) + 1) * GRU_CBR_AU_SIZE; (i)++)



/* Scan each DSR in a DSR bitmap. Note: multiple DSRs in an allocation unit */

#define for_each_dsr_in_allocation_map(i, map, k)			\

	for_each_set_bit((k), (const unsigned long *)(map), GRU_DSR_AU)	\

		for ((i) = (k) * GRU_DSR_AU_CL;				\

				(i) < ((k) + 1) * GRU_DSR_AU_CL; (i)++)



#define gseg_physical_address(gru, ctxnum)				\

		((gru)->gs_gru_base_paddr + ctxnum * GRU_GSEG_STRIDE)

#define gseg_virtual_address(gru, ctxnum)				\