Commit 20a02837 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Leon Romanovsky
Browse files

RDMA/rtrs: Require holding rcu_read_lock explicitly 



No functional change. The function get_next_path_rr needs to hold
rcu_read_lock. As such, if no rcu read lock, warnings will pop out.

Acked-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@linux.dev>
Link: https://lore.kernel.org/r/20230919073727.540207-1-yanjun.zhu@intel.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 81760bed

drivers/infiniband/ulp/rtrs/rtrs-clt.c

+6 −1
Original line number Diff line number Diff line
@@ -775,7 +775,7 @@ rtrs_clt_get_next_path_or_null(struct list_head *head, struct rtrs_clt_path *clt 
 * Related to @MP_POLICY_RR

 *

 * Locks:

 *    rcu_read_lock() must be hold.

 *    rcu_read_lock() must be held.

 */

static struct rtrs_clt_path *get_next_path_rr(struct path_it *it)

{
@@ -783,6 +783,11 @@ static struct rtrs_clt_path *get_next_path_rr(struct path_it *it) 
	struct rtrs_clt_path *path;

	struct rtrs_clt_sess *clt;



	/*

	 * Assert that rcu lock must be held

	 */

	RCU_LOCKDEP_WARN(!rcu_read_lock_held(), "no rcu read lock held");



	clt = it->clt;



	/*