Commit 1d31a831 authored Apr 07, 2021 by Johan Hovold Committed by Greg Kroah-Hartman Apr 07, 2021

tty: amiserial: fix TIOCSSERIAL permission check



Changing the port closing_wait parameter is a privileged operation.

Add the missing check to TIOCSSERIAL so that -EPERM is returned in case
an unprivileged user tries to change the closing-wait setting.

Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210407102334.32361-9-johan@kernel.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d38be702

drivers/tty/amiserial.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -970,6 +970,7 @@ static int set_serial_info(struct tty_struct tty, struct serial_struct ss)
		if (!serial_isroot()) {
		if ((ss->baud_base != state->baud_base) \|\|
		(ss->close_delay != port->close_delay) \|\|
		(ss->closing_wait != port->closing_wait) \|\|
		(ss->xmit_fifo_size != state->xmit_fifo_size) \|\|
		((ss->flags & ~ASYNC_USR_MASK) !=
		(port->flags & ~ASYNC_USR_MASK))) {