Commit 1d0f9ad7 authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Oded Gabbay
Browse files

accel/habanalabs: in hl_device_reset small refactor for readabilty 



in the out_err flow, combine the two cases of soft-reset since
they have mostly common code. In addition unlock reset_info.lock
after touching reset count.

Signed-off-by: default avatarDafna Hirschfeld <dhirschfeld@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
Reviewed-by: default avatarStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
parent 39ab4da9

drivers/accel/habanalabs/common/device.c

+8 −9
Original line number Diff line number Diff line
@@ -1852,17 +1852,16 @@ int hl_device_reset(struct hl_device *hdev, u32 flags) 
			"%s Failed to reset! Device is NOT usable\n",

			dev_name(&(hdev)->pdev->dev));

		hdev->reset_info.hard_reset_cnt++;

	} else if (reset_upon_device_release) {

		spin_unlock(&hdev->reset_info.lock);

	} else {

		if (reset_upon_device_release) {

			dev_err(hdev->dev, "Failed to reset device after user release\n");

		flags |= HL_DRV_RESET_HARD;

			flags &= ~HL_DRV_RESET_DEV_RELEASE;

		hard_reset = true;

		goto escalate_reset_flow;

		} else {

		spin_unlock(&hdev->reset_info.lock);

			dev_err(hdev->dev, "Failed to do compute reset\n");

			hdev->reset_info.compute_reset_cnt++;

		}



		spin_unlock(&hdev->reset_info.lock);

		flags |= HL_DRV_RESET_HARD;

		hard_reset = true;

		goto escalate_reset_flow;