Commit 1c7bfa15 authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: convert BUG_ON()'s in relocate_tree_block 



We have a couple of BUG_ON()'s in relocate_tree_block() that can be
tripped if we have file system corruption.  Convert these to ASSERT()'s
so developers still get yelled at when they break the backref code, but
error out nicely for users so the whole box doesn't go down.

Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent ffe30dd8

fs/btrfs/relocation.c

+22 −2
Original line number Diff line number Diff line
@@ -2454,8 +2454,28 @@ static int relocate_tree_block(struct btrfs_trans_handle *trans, 


	if (root) {

		if (test_bit(BTRFS_ROOT_SHAREABLE, &root->state)) {

			BUG_ON(node->new_bytenr);

			BUG_ON(!list_empty(&node->list));

			/*

			 * This block was the root block of a root, and this is

			 * the first time we're processing the block and thus it

			 * should not have had the ->new_bytenr modified and

			 * should have not been included on the changed list.

			 *

			 * However in the case of corruption we could have

			 * multiple refs pointing to the same block improperly,

			 * and thus we would trip over these checks.  ASSERT()

			 * for the developer case, because it could indicate a

			 * bug in the backref code, however error out for a

			 * normal user in the case of corruption.

			 */

			ASSERT(node->new_bytenr == 0);

			ASSERT(list_empty(&node->list));

			if (node->new_bytenr || !list_empty(&node->list)) {

				btrfs_err(root->fs_info,

				  "bytenr %llu has improper references to it",

					  node->bytenr);

				ret = -EUCLEAN;

				goto out;

			}

			btrfs_record_root_in_trans(trans, root);

			root = root->reloc_root;

			node->new_bytenr = root->node->start;