Commit 1b78dd34 authored by Johannes Berg's avatar Johannes Berg
Browse files

Revert "wifi: mac80211_hwsim: check the return value of nla_put_u32" 



This reverts commit b970ac68 ("wifi: mac80211_hwsim: check the
return value of nla_put_u32") since it introduced a memory leak in
the error path, which seems worse than sending an incomplete skb,
and the put can't fail anyway since the SKB was just allocated.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent a7a2ef0c

drivers/net/wireless/virtual/mac80211_hwsim.c

+2 −3
Original line number Diff line number Diff line
@@ -582,9 +582,8 @@ static int mac80211_hwsim_vendor_cmd_test(struct wiphy *wiphy, 
		 */



		/* Add vendor data */

		err = nla_put_u32(skb, QCA_WLAN_VENDOR_ATTR_TEST, val + 1);

		if (err)

			return err;

		nla_put_u32(skb, QCA_WLAN_VENDOR_ATTR_TEST, val + 1);



		/* Send the event - this will call nla_nest_end() */

		cfg80211_vendor_event(skb, GFP_KERNEL);

	}