Commit 1b22dcf6 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Dominik Brodowski
Browse files

pcmcia: pcmcia_resource: Replace mdelay() with msleep() 



pcmcia_fixup_iowidth() and pcmcia_enable_device() are
never called in atomic context.
They call mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
parent 5f17af05

drivers/pcmcia/pcmcia_resource.c

+2 −2
Original line number Diff line number Diff line
@@ -284,7 +284,7 @@ int pcmcia_fixup_iowidth(struct pcmcia_device *p_dev) 
		io_on.stop = s->io[i].res->end;



		s->ops->set_io_map(s, &io_off);

		mdelay(40);

		msleep(40);

		s->ops->set_io_map(s, &io_on);

	}

unlock:
@@ -567,7 +567,7 @@ int pcmcia_enable_device(struct pcmcia_device *p_dev) 
			!(flags & CONF_ENABLE_PULSE_IRQ))

			option |= COR_LEVEL_REQ;

		pcmcia_write_cis_mem(s, 1, (base + CISREG_COR)>>1, 1, &option);

		mdelay(40);

		msleep(40);

	}

	if (p_dev->config_regs & PRESENT_STATUS)

		pcmcia_write_cis_mem(s, 1, (base + CISREG_CCSR)>>1, 1, &status);