Commit 19b3102c authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David Teigland
Browse files

fs: dlm: Simplify buffer size computation in dlm_create_debug_file() 



Use sizeof(name) instead of the equivalent, but hard coded,
DLM_LOCKSPACE_LEN + 8.

This is less verbose and more future proof.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
parent 94f6f055

fs/dlm/debug_fs.c

+5 −5
Original line number Diff line number Diff line
@@ -986,7 +986,7 @@ void dlm_create_debug_file(struct dlm_ls *ls) 
	/* format 2 */



	memset(name, 0, sizeof(name));

	snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_locks", ls->ls_name);

	snprintf(name, sizeof(name), "%s_locks", ls->ls_name);



	ls->ls_debug_locks_dentry = debugfs_create_file(name,

							0644,
@@ -997,7 +997,7 @@ void dlm_create_debug_file(struct dlm_ls *ls) 
	/* format 3 */



	memset(name, 0, sizeof(name));

	snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_all", ls->ls_name);

	snprintf(name, sizeof(name), "%s_all", ls->ls_name);



	ls->ls_debug_all_dentry = debugfs_create_file(name,

						      S_IFREG | S_IRUGO,
@@ -1008,7 +1008,7 @@ void dlm_create_debug_file(struct dlm_ls *ls) 
	/* format 4 */



	memset(name, 0, sizeof(name));

	snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_toss", ls->ls_name);

	snprintf(name, sizeof(name), "%s_toss", ls->ls_name);



	ls->ls_debug_toss_dentry = debugfs_create_file(name,

						       S_IFREG | S_IRUGO,
@@ -1017,7 +1017,7 @@ void dlm_create_debug_file(struct dlm_ls *ls) 
						       &format4_fops);



	memset(name, 0, sizeof(name));

	snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_waiters", ls->ls_name);

	snprintf(name, sizeof(name), "%s_waiters", ls->ls_name);



	ls->ls_debug_waiters_dentry = debugfs_create_file(name,

							  0644,
@@ -1028,7 +1028,7 @@ void dlm_create_debug_file(struct dlm_ls *ls) 
	/* format 5 */



	memset(name, 0, sizeof(name));

	snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_queued_asts", ls->ls_name);

	snprintf(name, sizeof(name), "%s_queued_asts", ls->ls_name);



	ls->ls_debug_queued_asts_dentry = debugfs_create_file(name,

							      0644,