Commit 19444ae9 authored by Philipp Hortmann's avatar Philipp Hortmann Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192e: Remove useless equation in debug output 



When "switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl)))" results
in "case RTLLIB_STYPE_BEACON:" there is no need to calculate this again
inside "case" and when a frame is a beacon there is no need to print the
frame identifier again as it is explicit.
Same for PROBE RESPONSE and PROBE REQUEST. Remove dead code.

Signed-off-by: default avatarPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/f3c8deddac66d11c41ba720e4048aba37e41e885.1694546300.git.philipp.g.hortmann@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b50d2a8c

drivers/staging/rtl8192e/rtllib_rx.c

+3 −6
Original line number Diff line number Diff line
@@ -2652,8 +2652,7 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee, 


	switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))) {

	case RTLLIB_STYPE_BEACON:

		netdev_dbg(ieee->dev, "received BEACON (%d)\n",

			   WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl)));

		netdev_dbg(ieee->dev, "received BEACON\n");

		rtllib_process_probe_response(

				ieee, (struct rtllib_probe_response *)header,

				stats);
@@ -2666,14 +2665,12 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee, 
		break;



	case RTLLIB_STYPE_PROBE_RESP:

		netdev_dbg(ieee->dev, "received PROBE RESPONSE (%d)\n",

			   WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl)));

		netdev_dbg(ieee->dev, "received PROBE RESPONSE\n");

		rtllib_process_probe_response(ieee,

			      (struct rtllib_probe_response *)header, stats);

		break;

	case RTLLIB_STYPE_PROBE_REQ:

		netdev_dbg(ieee->dev, "received PROBE REQUEST (%d)\n",

			   WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl)));

		netdev_dbg(ieee->dev, "received PROBE REQUEST\n");

		if ((ieee->softmac_features & IEEE_SOFTMAC_PROBERS) &&

		    (ieee->iw_mode == IW_MODE_ADHOC &&

		    ieee->link_state == MAC80211_LINKED))