Commit 18c98714 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde
Browse files

can: at91_can: at91_irq_tx(): remove one level of indention 

Improve code readability by removing one level of indention.

If a mailbox is not ready, continue the loop early.

Link: https://lore.kernel.org/all/20231005-at91_can-rx_offload-v2-3-9987d53600e0@pengutronix.de


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent e26ccc46

drivers/net/can/at91_can.c

+8 −9
Original line number Diff line number Diff line
@@ -844,16 +844,15 @@ static void at91_irq_tx(struct net_device *dev, u32 reg_sr) 
		 * parked in the echo queue.

		 */

		reg_msr = at91_read(priv, AT91_MSR(mb));

		if (likely(reg_msr & AT91_MSR_MRDY &&

			   ~reg_msr & AT91_MSR_MABT)) {

		if (unlikely(!(reg_msr & AT91_MSR_MRDY &&

			       ~reg_msr & AT91_MSR_MABT)))

			continue;



		/* _NOTE_: subtract AT91_MB_TX_FIRST offset from mb! */

		dev->stats.tx_bytes +=

				can_get_echo_skb(dev,

						 mb - get_mb_tx_first(priv),

						 NULL);

			can_get_echo_skb(dev, mb - get_mb_tx_first(priv), NULL);

		dev->stats.tx_packets++;

	}

	}



	/* restart queue if we don't have a wrap around but restart if

	 * we get a TX int for the last can frame directly before a