Commit 17b2fb9c authored by Lin Ma's avatar Lin Ma Committed by Greg Kroah-Hartman
Browse files

usb-storage: alauda: fix initFunction error return 



The initFunction is called when probing a new device, its call relation
is like:

USB core: probe() -> usb_stor_probe2() -> usb_stor_acquire_resources()
-> init_alauda()

That is, the error return of the initFunction should tell USB core what
happened instead of using error code like USB_STOR_TRANSPORT_ERROR.

Signed-off-by: default avatarLin Ma <linma@zju.edu.cn>
Link: https://lore.kernel.org/r/20220407022058.3741-1-linma@zju.edu.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eafc69a4

drivers/usb/storage/alauda.c

+2 −2
Original line number Diff line number Diff line
@@ -1104,7 +1104,7 @@ static int init_alauda(struct us_data *us) 


	us->extra = kzalloc(sizeof(struct alauda_info), GFP_NOIO);

	if (!us->extra)

		return USB_STOR_TRANSPORT_ERROR;

		return -ENOMEM;



	info = (struct alauda_info *) us->extra;

	us->extra_destructor = alauda_info_destructor;
@@ -1113,7 +1113,7 @@ static int init_alauda(struct us_data *us) 
		altsetting->endpoint[0].desc.bEndpointAddress

		& USB_ENDPOINT_NUMBER_MASK);



	return USB_STOR_TRANSPORT_GOOD;

	return 0;

}



static int alauda_transport(struct scsi_cmnd *srb, struct us_data *us)