Commit 1771e9fb authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mauro Carvalho Chehab
Browse files

media: Use fallthrough pseudo-keyword 

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through



Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent d7a81a5b

drivers/media/cec/core/cec-adap.c

+1 −1
Original line number Diff line number Diff line
@@ -1928,7 +1928,7 @@ static int cec_receive_notify(struct cec_adapter *adap, struct cec_msg *msg, 
		 */

		if (!adap->passthrough && from_unregistered)

			return 0;

		/* Fall through */

		fallthrough;

	case CEC_MSG_GIVE_DEVICE_VENDOR_ID:

	case CEC_MSG_GIVE_FEATURES:

	case CEC_MSG_GIVE_PHYSICAL_ADDR:

drivers/media/cec/core/cec-pin.c

+3 −3
Original line number Diff line number Diff line
@@ -417,7 +417,7 @@ static void cec_pin_tx_states(struct cec_pin *pin, ktime_t ts) 
			wake_up_interruptible(&pin->kthread_waitq);

			break;

		}

		/* fall through */

		fallthrough;

	case CEC_ST_TX_DATA_BIT_0_HIGH:

	case CEC_ST_TX_DATA_BIT_0_HIGH_SHORT:

	case CEC_ST_TX_DATA_BIT_0_HIGH_LONG:
@@ -445,7 +445,7 @@ static void cec_pin_tx_states(struct cec_pin *pin, ktime_t ts) 
			wake_up_interruptible(&pin->kthread_waitq);

			break;

		}

		/* fall through */

		fallthrough;

	case CEC_ST_TX_DATA_BIT_HIGH_CUSTOM:

		if (tx_last_bit(pin)) {

			/* Error Injection: just stop sending after this bit */
@@ -459,7 +459,7 @@ static void cec_pin_tx_states(struct cec_pin *pin, ktime_t ts) 
			break;

		}

		pin->tx_bit++;

		/* fall through */

		fallthrough;

	case CEC_ST_TX_START_BIT_HIGH:

	case CEC_ST_TX_START_BIT_HIGH_SHORT:

	case CEC_ST_TX_START_BIT_HIGH_LONG:

drivers/media/cec/usb/pulse8/pulse8-cec.c

+1 −1
Original line number Diff line number Diff line
@@ -389,7 +389,7 @@ static irqreturn_t pulse8_interrupt(struct serio *serio, unsigned char data, 
				pulse8->new_rx_msg[0] = pulse8->buf[1];

				break;

			}

			/* fall through */

			fallthrough;

		case MSGCODE_FRAME_DATA:

			if (pulse8->new_rx_msg_len < CEC_MAX_MSG_SIZE)

				pulse8->new_rx_msg[pulse8->new_rx_msg_len++] =

drivers/media/common/videobuf2/videobuf2-v4l2.c

+1 −1
Original line number Diff line number Diff line
@@ -601,7 +601,7 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, void *pb) 
		break;

	case VB2_BUF_STATE_ERROR:

		b->flags |= V4L2_BUF_FLAG_ERROR;

		/* fall through */

		fallthrough;

	case VB2_BUF_STATE_DONE:

		b->flags |= V4L2_BUF_FLAG_DONE;

		break;

drivers/media/dvb-frontends/af9013.c

+1 −1
Original line number Diff line number Diff line
@@ -597,7 +597,7 @@ static int af9013_read_status(struct dvb_frontend *fe, enum fe_status *status) 
			state->strength_en = 2;

			break;

		}

		/* Fall through */

		fallthrough;

	case 1:

		if (time_is_after_jiffies(state->strength_jiffies + msecs_to_jiffies(2000)))

			break;