Commit 1760435d authored by Suwan Kim's avatar Suwan Kim Committed by Greg Kroah-Hartman
Browse files

usb: core: Move variable initialization to appropriate place 



It is better to initialize the variable 'cfgno' in the for loop than
at the current place.

Signed-off-by: default avatarSuwan Kim <suwan.kim027@gmail.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a2fd23b9

drivers/usb/core/config.c

+1 −2
Original line number Diff line number Diff line
@@ -805,7 +805,6 @@ int usb_get_configuration(struct usb_device *dev) 
	unsigned char *bigbuffer;

	struct usb_config_descriptor *desc;



	cfgno = 0;

	if (ncfg > USB_MAXCONFIG) {

		dev_warn(ddev, "too many configurations: %d, "

		    "using maximum allowed: %d\n", ncfg, USB_MAXCONFIG);
@@ -831,7 +830,7 @@ int usb_get_configuration(struct usb_device *dev) 
	if (!desc)

		goto err2;



	for (; cfgno < ncfg; cfgno++) {

	for (cfgno = 0; cfgno < ncfg; cfgno++) {

		/* We grab just the first descriptor so we know how long

		 * the whole configuration is */

		result = usb_get_descriptor(dev, USB_DT_CONFIG, cfgno,