Commit 1728bf64 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/ast: Use managed mode-config init 



Using drmm_mode_config_init() sets up managed release of modesetting
resources. The existing modesetting's finalizer is empty, so remove it.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200702115029.5281-14-tzimmermann@suse.de
parent c35da0ed

drivers/gpu/drm/ast/ast_drv.h

+0 −1
Original line number Diff line number Diff line
@@ -287,7 +287,6 @@ struct ast_crtc_state { 
#define to_ast_crtc_state(state) container_of(state, struct ast_crtc_state, base)



extern int ast_mode_init(struct drm_device *dev);

extern void ast_mode_fini(struct drm_device *dev);



#define AST_MM_ALIGN_SHIFT 4

#define AST_MM_ALIGN_MASK ((1 << AST_MM_ALIGN_SHIFT) - 1)

drivers/gpu/drm/ast/ast_main.c

+3 −3
Original line number Diff line number Diff line
@@ -473,7 +473,9 @@ int ast_driver_load(struct drm_device *dev, unsigned long flags) 
	if (ret)

		goto out_free;



	drm_mode_config_init(dev);

	ret = drmm_mode_config_init(dev);

	if (ret)

		goto out_free;



	dev->mode_config.funcs = (void *)&ast_mode_funcs;

	dev->mode_config.min_width = 0;
@@ -516,8 +518,6 @@ void ast_driver_unload(struct drm_device *dev) 


	ast_release_firmware(dev);

	kfree(ast->dp501_fw_addr);

	ast_mode_fini(dev);

	drm_mode_config_cleanup(dev);



	ast_mm_fini(ast);

	kfree(ast);

drivers/gpu/drm/ast/ast_mode.c

+0 −4
Original line number Diff line number Diff line
@@ -1110,10 +1110,6 @@ int ast_mode_init(struct drm_device *dev) 
	return 0;

}



void ast_mode_fini(struct drm_device *dev)

{

}



static int get_clock(void *i2c_priv)

{

	struct ast_i2c_chan *i2c = i2c_priv;