Commit 14bf1c47 authored by Darren Powell's avatar Darren Powell Committed by Alex Deucher
Browse files

amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 3 



   split switch statement into two and consolidate the common
   code for printing most of the types of clock speeds

Signed-off-by: default avatarDarren Powell <darren.powell@amd.com>
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent d62846f7

drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c

+27 −55
Original line number Diff line number Diff line
@@ -788,17 +788,6 @@ static int aldebaran_emit_clk_levels(struct smu_context *smu, 
			freq_values[2] = max_clk;

			freq_values[1] = cur_value;

		}



		for (i = 0; i < display_levels; i++) {

			clock_mhz = freq_values[i];

			freq_match = aldebaran_freqs_in_same_level(clock_mhz, cur_value);

			freq_match |= (display_levels == 1);



			*offset += sysfs_emit_at(buf, *offset, "%d: %uMhz %s\n", i,

				clock_mhz,

				(freq_match) ? "*" : "");

		}



		break;



	case SMU_OD_MCLK:
@@ -813,16 +802,6 @@ static int aldebaran_emit_clk_levels(struct smu_context *smu, 


		single_dpm_table = &(dpm_context->dpm_tables.uclk_table);

		aldebaran_get_clk_table(smu, &clocks, single_dpm_table);



		for (i = 0; i < clocks.num_levels; i++) {

			clock_mhz = clocks.data[i].clocks_in_khz / 1000;

			freq_match = aldebaran_freqs_in_same_level(clock_mhz, cur_value);

			freq_match |= (clocks.num_levels == 1);



			*offset += sysfs_emit_at(buf, *offset, "%d: %uMhz %s\n",

					i, clock_mhz,

					(freq_match) ? "*" : "");

		}

		break;



	case SMU_SOCCLK:
@@ -834,16 +813,6 @@ static int aldebaran_emit_clk_levels(struct smu_context *smu, 


		single_dpm_table = &(dpm_context->dpm_tables.soc_table);

		aldebaran_get_clk_table(smu, &clocks, single_dpm_table);



		for (i = 0; i < clocks.num_levels; i++) {

			clock_mhz = clocks.data[i].clocks_in_khz / 1000;

			freq_match = aldebaran_freqs_in_same_level(clock_mhz, cur_value);

			freq_match |= (clocks.num_levels == 1);



			*offset += sysfs_emit_at(buf, *offset, "%d: %uMhz %s\n",

					i, clock_mhz,

					(freq_match) ? "*" : "");

		}

		break;



	case SMU_FCLK:
@@ -855,16 +824,6 @@ static int aldebaran_emit_clk_levels(struct smu_context *smu, 


		single_dpm_table = &(dpm_context->dpm_tables.fclk_table);

		aldebaran_get_clk_table(smu, &clocks, single_dpm_table);



		for (i = 0; i < clocks.num_levels; i++) {

			clock_mhz = clocks.data[i].clocks_in_khz / 1000;

			freq_match = aldebaran_freqs_in_same_level(clock_mhz, cur_value);

			freq_match |= (clocks.num_levels == 1);



			*offset += sysfs_emit_at(buf, *offset, "%d: %uMhz %s\n",

					i, clock_mhz,

					(freq_match) ? "*" : "");

		}

		break;



	case SMU_VCLK:
@@ -876,16 +835,6 @@ static int aldebaran_emit_clk_levels(struct smu_context *smu, 


		single_dpm_table = &(dpm_context->dpm_tables.vclk_table);

		aldebaran_get_clk_table(smu, &clocks, single_dpm_table);



		for (i = 0; i < clocks.num_levels; i++) {

			clock_mhz = clocks.data[i].clocks_in_khz / 1000;

			freq_match = aldebaran_freqs_in_same_level(clock_mhz, cur_value);

			freq_match |= (clocks.num_levels == 1);



			*offset += sysfs_emit_at(buf, *offset, "%d: %uMhz %s\n",

					i, clock_mhz,

					(freq_match) ? "*" : "");

		}

		break;



	case SMU_DCLK:
@@ -897,7 +846,32 @@ static int aldebaran_emit_clk_levels(struct smu_context *smu, 


		single_dpm_table = &(dpm_context->dpm_tables.dclk_table);

		aldebaran_get_clk_table(smu, &clocks, single_dpm_table);

		break;



	default:

		return -EINVAL;

	}



	switch (type) {

	case SMU_OD_SCLK:

	case SMU_SCLK:

		for (i = 0; i < display_levels; i++) {

			clock_mhz = freq_values[i];

			freq_match = aldebaran_freqs_in_same_level(clock_mhz, cur_value);

			freq_match |= (display_levels == 1);



			*offset += sysfs_emit_at(buf, *offset, "%d: %uMhz %s\n", i,

				clock_mhz,

				(freq_match) ? "*" : "");

		}

		break;



	case SMU_OD_MCLK:

	case SMU_MCLK:

	case SMU_SOCCLK:

	case SMU_FCLK:

	case SMU_VCLK:

	case SMU_DCLK:

		for (i = 0; i < clocks.num_levels; i++) {

			clock_mhz = clocks.data[i].clocks_in_khz / 1000;

			freq_match = aldebaran_freqs_in_same_level(clock_mhz, cur_value);
@@ -908,10 +882,8 @@ static int aldebaran_emit_clk_levels(struct smu_context *smu, 
				(freq_match) ? "*" : "");

		}

		break;



	default:

		return -EINVAL;

		break;

	}



	return 0;