Commit 14b32138 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Martin K. Petersen
Browse files

scsi: sun3x_esp: Add IRQ check 

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to request_irq() (which takes
*unsigned* IRQ #), causing it to fail with -EINVAL, overriding the real
error code.  Stop calling request_irq() with the invalid IRQ #s.

Link: https://lore.kernel.org/r/363eb4c8-a3bf-4dc9-2a9e-90f349030a15@omprussia.ru


Fixes: 0bb67f18 ("[SCSI] sun3x_esp: convert to esp_scsi")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 38fca15c

drivers/scsi/sun3x_esp.c

+3 −1
Original line number Diff line number Diff line
@@ -206,7 +206,9 @@ static int esp_sun3x_probe(struct platform_device *dev) 
	if (!esp->command_block)

		goto fail_unmap_regs_dma;



	host->irq = platform_get_irq(dev, 0);

	host->irq = err = platform_get_irq(dev, 0);

	if (err < 0)

		goto fail_unmap_command_block;

	err = request_irq(host->irq, scsi_esp_intr, IRQF_SHARED,

			  "SUN3X ESP", esp);

	if (err < 0)