Unverified Commit 13a75c3a authored by Wedson Almeida Filho's avatar Wedson Almeida Filho Committed by Christian Brauner
Browse files

jffs2: move jffs2_xattr_handlers to .rodata 



This makes it harder for accidental or malicious changes to
jffs2_xattr_handlers at runtime.

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: default avatarWedson Almeida Filho <walmeida@microsoft.com>
Link: https://lore.kernel.org/r/20230930050033.41174-16-wedsonaf@gmail.com


Reviewed-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 2c323f2c

fs/jffs2/xattr.c

+1 −1
Original line number Diff line number Diff line
@@ -920,7 +920,7 @@ struct jffs2_xattr_datum *jffs2_setup_xattr_datum(struct jffs2_sb_info *c, 
 * do_jffs2_setxattr(inode, xprefix, xname, buffer, size, flags)

 *   is an implementation of setxattr handler on jffs2.

 * -------------------------------------------------- */

const struct xattr_handler *jffs2_xattr_handlers[] = {

const struct xattr_handler * const jffs2_xattr_handlers[] = {

	&jffs2_user_xattr_handler,

#ifdef CONFIG_JFFS2_FS_SECURITY

	&jffs2_security_xattr_handler,

fs/jffs2/xattr.h

+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ extern int do_jffs2_getxattr(struct inode *inode, int xprefix, const char *xname 
extern int do_jffs2_setxattr(struct inode *inode, int xprefix, const char *xname,

			     const char *buffer, size_t size, int flags);



extern const struct xattr_handler *jffs2_xattr_handlers[];

extern const struct xattr_handler * const jffs2_xattr_handlers[];

extern const struct xattr_handler jffs2_user_xattr_handler;

extern const struct xattr_handler jffs2_trusted_xattr_handler;