Commit 12d133de authored by Koby Elbaz's avatar Koby Elbaz Committed by Oded Gabbay
Browse files

habanalabs: small code refactoring 



Use datatype defines instead of hard coded values,
and rename set_fixed_properties function.

Signed-off-by: default avatarKoby Elbaz <kelbaz@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent f1a29770

drivers/misc/habanalabs/common/device.c

+1 −1
Original line number Diff line number Diff line
@@ -1395,7 +1395,7 @@ int hl_device_init(struct hl_device *hdev, struct class *hclass) 


	dev_info(hdev->dev, "Found %s device with %lluGB DRAM\n",

		hdev->asic_name,

		hdev->asic_prop.dram_size / 1024 / 1024 / 1024);

		hdev->asic_prop.dram_size / SZ_1G);



	rc = hl_vm_init(hdev);

	if (rc) {

drivers/misc/habanalabs/gaudi/gaudi.c

+3 −3
Original line number Diff line number Diff line
@@ -410,7 +410,7 @@ static inline void set_default_power_values(struct hl_device *hdev) 
	}

}



static int gaudi_get_fixed_properties(struct hl_device *hdev)

static int gaudi_set_fixed_properties(struct hl_device *hdev)

{

	struct asic_fixed_properties *prop = &hdev->asic_prop;

	u32 num_sync_stream_queues = 0;
@@ -655,9 +655,9 @@ static int gaudi_early_init(struct hl_device *hdev) 
	u32 fw_boot_status;

	int rc;



	rc = gaudi_get_fixed_properties(hdev);

	rc = gaudi_set_fixed_properties(hdev);

	if (rc) {

		dev_err(hdev->dev, "Failed to get fixed properties\n");

		dev_err(hdev->dev, "Failed setting fixed properties\n");

		return rc;

	}

drivers/misc/habanalabs/goya/goya.c

+2 −2
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ static int goya_mmu_set_dram_default_page(struct hl_device *hdev); 
static int goya_mmu_add_mappings_for_device_cpu(struct hl_device *hdev);

static void goya_mmu_prepare(struct hl_device *hdev, u32 asid);



int goya_get_fixed_properties(struct hl_device *hdev)

int goya_set_fixed_properties(struct hl_device *hdev)

{

	struct asic_fixed_properties *prop = &hdev->asic_prop;

	int i;
@@ -587,7 +587,7 @@ static int goya_early_init(struct hl_device *hdev) 
	u32 fw_boot_status, val;

	int rc;



	rc = goya_get_fixed_properties(hdev);

	rc = goya_set_fixed_properties(hdev);

	if (rc) {

		dev_err(hdev->dev, "Failed to get fixed properties\n");

		return rc;

drivers/misc/habanalabs/goya/goyaP.h

+1 −1
Original line number Diff line number Diff line
@@ -168,7 +168,7 @@ struct goya_device { 
	u8		device_cpu_mmu_mappings_done;

};



int goya_get_fixed_properties(struct hl_device *hdev);

int goya_set_fixed_properties(struct hl_device *hdev);

int goya_mmu_init(struct hl_device *hdev);

void goya_init_dma_qmans(struct hl_device *hdev);

void goya_init_mme_qmans(struct hl_device *hdev);