Commit 1023ab9c authored by Vaibhav Agarwal's avatar Vaibhav Agarwal Committed by Greg Kroah-Hartman
Browse files

staging: greybus: audio: Initialize sig_bits before configuring hwparams 



Uninitialized variable sig_bits was used while configuring stream params
for codec module. These params are used to configure PCM settings for
APBridgeA.

Usually, this is dependent on codec capability and thus populated via
codec dai_driver definition. In our case, it is fixed to 16 based on the
data format, container supported.

Signed-off-by: default avatarVaibhav Agarwal <vaibhav.agarwal@linaro.org>
Signed-off-by: default avatarVaibhav Agarwal <vaibhav.sr@gmail.com>
Acked-by: default avatarMark Greer <mgreer@animalcreek.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 84510052

drivers/staging/greybus/audio_codec.c

+7 −0
Original line number Diff line number Diff line
@@ -496,6 +496,11 @@ static int gbcodec_hw_params(struct snd_pcm_substream *substream, 


	gb_pm_runtime_put_noidle(bundle);



	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)

		sig_bits = dai->driver->playback.sig_bits;

	else

		sig_bits = dai->driver->capture.sig_bits;



	params->state = GBAUDIO_CODEC_HWPARAMS;

	params->format = format;

	params->rate = rate;
@@ -689,6 +694,7 @@ static struct snd_soc_dai_driver gbaudio_dai[] = { 
			.rate_min = 48000,

			.channels_min = 1,

			.channels_max = 2,

			.sig_bits = 16,

		},

		.capture = {

			.stream_name = "I2S 0 Capture",
@@ -698,6 +704,7 @@ static struct snd_soc_dai_driver gbaudio_dai[] = { 
			.rate_min = 48000,

			.channels_min = 1,

			.channels_max = 2,

			.sig_bits = 16,

		},

		.ops = &gbcodec_dai_ops,

	},