Commit 0d5fea42 authored by Lee Jones's avatar Lee Jones Committed by Martin K. Petersen
Browse files

scsi: qla4xxx: Fix-up incorrectly documented parameter 

Also demote incomplete header from kerneldoc.

Fixes the following W=1 kernel build warning(s):

from  drivers/scsi/qla4xxx/ql4_mbx.c:9:
 drivers/scsi/qla4xxx/ql4_mbx.c:53: warning: Excess function parameter 'ret' description in 'qla4xxx_is_intr_poll_mode'
 drivers/scsi/qla4xxx/ql4_mbx.c:832: warning: Function parameter or member 'fw_ddb_entry_dma' not described in 'qla4xxx_get_fwddb_entry'
 drivers/scsi/qla4xxx/ql4_mbx.c:832: warning: Function parameter or member 'conn_err_detail' not described in 'qla4xxx_get_fwddb_entry'
 drivers/scsi/qla4xxx/ql4_mbx.c:832: warning: Function parameter or member 'tcp_source_port_num' not described in 'qla4xxx_get_fwddb_entry'
 drivers/scsi/qla4xxx/ql4_mbx.c:832: warning: Function parameter or member 'connection_id' not described in 'qla4xxx_get_fwddb_entry'
 drivers/scsi/qla4xxx/ql4_mbx.c:1271: warning: Function parameter or member 'ddb_entry' not described in 'qla4xxx_reset_target'
 drivers/scsi/qla4xxx/ql4_mbx.c:1271: warning: Excess function parameter 'db_entry' description in 'qla4xxx_reset_target'
 drivers/scsi/qla4xxx/ql4_mbx.c:1271: warning: Excess function parameter 'un_entry' description in 'qla4xxx_reset_target'

Link: https://lore.kernel.org/r/20200721164148.2617584-22-lee.jones@linaro.org


Cc: QLogic-Storage-Upstream@qlogic.com
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3c1311ad

drivers/scsi/qla4xxx/ql4_mbx.c

+3 −4
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ void qla4xxx_process_mbox_intr(struct scsi_qla_host *ha, int out_count) 
/**

 * qla4xxx_is_intr_poll_mode – Are we allowed to poll for interrupts?

 * @ha: Pointer to host adapter structure.

 * @ret: 1=polling mode, 0=non-polling mode

 * returns: 1=polling mode, 0=non-polling mode

 **/

static int qla4xxx_is_intr_poll_mode(struct scsi_qla_host *ha)

{
@@ -810,7 +810,7 @@ int qla4xxx_get_firmware_status(struct scsi_qla_host * ha) 
	return QLA_SUCCESS;

}



/**

/*

 * qla4xxx_get_fwddb_entry - retrieves firmware ddb entry

 * @ha: Pointer to host adapter structure.

 * @fw_ddb_index: Firmware's device database index
@@ -1259,8 +1259,7 @@ int qla4xxx_reset_lun(struct scsi_qla_host * ha, struct ddb_entry * ddb_entry, 
/**

 * qla4xxx_reset_target - issues target Reset

 * @ha: Pointer to host adapter structure.

 * @db_entry: Pointer to device database entry

 * @un_entry: Pointer to lun entry structure

 * @ddb_entry: Pointer to device database entry

 *

 * This routine performs a TARGET RESET on the specified target.

 * The caller must ensure that the ddb_entry pointers