Commit 08d4c174 authored by Rob Herring's avatar Rob Herring Committed by Thomas Gleixner
Browse files

irqchip/ls-scfg-msi: Use device_get_match_data() 



Use preferred device_get_match_data() instead of of_match_device() to
get the driver match data in a single step without the unnecessary
intermediate match pointer.

With this, adjust the includes to explicitly include the correct
headers. That also serves as preparation to remove implicit includes within
the DT headers.  of_platform.h currently includes platform_device.h among
others.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20231020130255.2954415-3-robh@kernel.org
parent 5e7afb2e

drivers/irqchip/irq-ls-scfg-msi.c

+5 −7
Original line number Diff line number Diff line
@@ -17,7 +17,8 @@ 
#include <linux/irqdomain.h>

#include <linux/of_irq.h>

#include <linux/of_pci.h>

#include <linux/of_platform.h>

#include <linux/platform_device.h>

#include <linux/property.h>

#include <linux/spinlock.h>



#define MSI_IRQS_PER_MSIR	32
@@ -334,20 +335,17 @@ MODULE_DEVICE_TABLE(of, ls_scfg_msi_id); 


static int ls_scfg_msi_probe(struct platform_device *pdev)

{

	const struct of_device_id *match;

	struct ls_scfg_msi *msi_data;

	struct resource *res;

	int i, ret;



	match = of_match_device(ls_scfg_msi_id, &pdev->dev);

	if (!match)

		return -ENODEV;



	msi_data = devm_kzalloc(&pdev->dev, sizeof(*msi_data), GFP_KERNEL);

	if (!msi_data)

		return -ENOMEM;



	msi_data->cfg = (struct ls_scfg_msi_cfg *) match->data;

	msi_data->cfg = (struct ls_scfg_msi_cfg *)device_get_match_data(&pdev->dev);

	if (!msi_data->cfg)

		return -ENODEV;



	msi_data->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);

	if (IS_ERR(msi_data->regs)) {