Commit 048449fc authored by Mukesh Sisodiya's avatar Mukesh Sisodiya Committed by Johannes Berg
Browse files

wifi: iwlwifi: fw: Fix debugfs command sending 



During debugfs command handling transport function is used directly,
this bypasses the locking used by runtime operation function
and leads to a kernel warning when two commands are
sent in parallel.

Fix it by using runtime operations function when sending
debugfs command.

Signed-off-by: default avatarMukesh Sisodiya <mukesh.sisodiya@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20231004123422.4f80ac90658a.Ia1dfa1195c919f3002fe08db3eefbd2bfa921bbf@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 3f5e8522

drivers/net/wireless/intel/iwlwifi/fw/debugfs.c

+5 −1
Original line number Diff line number Diff line
@@ -141,7 +141,11 @@ static int iwl_dbgfs_enabled_severities_write(struct iwl_fw_runtime *fwrt, 


	event_cfg.enabled_severities = cpu_to_le32(enabled_severities);



	ret = iwl_trans_send_cmd(fwrt->trans, &hcmd);

	if (fwrt->ops && fwrt->ops->send_hcmd)

		ret = fwrt->ops->send_hcmd(fwrt->ops_ctx, &hcmd);

	else

		ret = -EPERM;



	IWL_INFO(fwrt,

		 "sent host event cfg with enabled_severities: %u, ret: %d\n",

		 enabled_severities, ret);