Commit 03721992 authored May 11, 2021 by Pierre-Louis Bossart Committed by Vinod Koul May 11, 2021

soundwire: dmi-quirks: remove duplicate initialization



cppcheck warning:

drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
for 'map'. The initialized value is overwritten before it is
read. [redundantInitialization]
  for (map = dmi_id->driver_data; map->adr; map++) {
           ^
drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
  struct adr_remap *map = dmi_id->driver_data;
                        ^
drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
  for (map = dmi_id->driver_data; map->adr; map++) {
           ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210511025035.25233-1-yung-chuan.liao@linux.intel.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 36eee232

drivers/soundwire/dmi-quirks.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -80,7 +80,7 @@ u64 sdw_dmi_override_adr(struct sdw_bus *bus, u64 addr)
		/* check if any address remap quirk applies */
		dmi_id = dmi_first_match(adr_remap_quirk_table);
		if (dmi_id) {
		struct adr_remap *map = dmi_id->driver_data;
		struct adr_remap *map;

		for (map = dmi_id->driver_data; map->adr; map++) {
		if (map->adr == addr) {