Commit 01aad7b6 authored by Ben Hutchings's avatar Ben Hutchings Committed by Jeff Garzik
Browse files

sfc: Remove efx_nic_dummy_op_int() as redundant with efx_port_dummy_op_int() 



Update comment on the dummy operation implementations.

Line up the board operation initialisers.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 740847da

drivers/net/sfc/efx.c

+6 −11
Original line number Diff line number Diff line
@@ -1774,7 +1774,7 @@ static struct pci_device_id efx_pci_table[] __devinitdata = { 
 *

 * Dummy PHY/MAC/Board operations

 *

 * Can be used where the MAC does not implement this operation

 * Can be used for some unimplemented operations

 * Needed so all function pointers are valid and do not have to be tested

 * before use

 *
@@ -1795,16 +1795,11 @@ static struct efx_phy_operations efx_dummy_phy_operations = { 
	.reset_xaui      = efx_port_dummy_op_void,

};



/* Dummy board operations */

static int efx_nic_dummy_op_int(struct efx_nic *nic)

{

	return 0;

}



static struct efx_board efx_dummy_board_info = {

	.init    = efx_nic_dummy_op_int,

	.init		= efx_port_dummy_op_int,

	.init_leds	= efx_port_dummy_op_int,

	.set_fault_led	= efx_port_dummy_op_blink,

	.blink		= efx_port_dummy_op_blink,

	.fini		= efx_port_dummy_op_void,

};