Commit 001b48b6 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: drop contiguous argument from ia_css_frame_allocate_with_buffer_size() 

Drop the contiguous argument from ia_css_frame_allocate_with_buffer_size()
its only caller always passes false.

Link: https://lore.kernel.org/linux-media/20220615205037.16549-4-hdegoede@redhat.com


Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 7c6b6a5b

drivers/staging/media/atomisp/pci/runtime/frame/interface/ia_css_frame.h

+2 −5
Original line number Diff line number Diff line
@@ -109,16 +109,13 @@ void ia_css_frame_free_multiple(unsigned int num_frames, 
 *

 * @param	frame	The allocated frame.

 * @param[in]	size_bytes	The frame size in bytes.

 * @param[in]	contiguous	Allocate memory physically contiguously or not.

 * @return	The error code.

 *

 * Allocate a frame using the given size in bytes.

 * The frame structure is partially null initialized.

 */

int ia_css_frame_allocate_with_buffer_size(

    struct ia_css_frame **frame,

    const unsigned int size_bytes,

    const bool contiguous);

int ia_css_frame_allocate_with_buffer_size(struct ia_css_frame **frame,

					   const unsigned int size_bytes);



/* @brief Check whether 2 frames are same type

 *

drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c

+3 −5
Original line number Diff line number Diff line
@@ -486,16 +486,14 @@ void ia_css_frame_free_multiple(unsigned int num_frames, 
	}

}



int ia_css_frame_allocate_with_buffer_size(

    struct ia_css_frame **frame,

    const unsigned int buffer_size_bytes,

    const bool contiguous)

int ia_css_frame_allocate_with_buffer_size(struct ia_css_frame **frame,

					   const unsigned int buffer_size_bytes)

{

	/* AM: Body coppied from frame_allocate_with_data(). */

	int err;

	struct ia_css_frame *me = frame_create(0, 0,

					       IA_CSS_FRAME_FORMAT_NUM,/* Not valid format yet */

					       0, 0, contiguous, false);

					       0, 0, false, false);



	if (!me)

		return -ENOMEM;

drivers/staging/media/atomisp/pci/sh_css_mipi.c

+1 −2
Original line number Diff line number Diff line
@@ -431,8 +431,7 @@ allocate_mipi_frames(struct ia_css_pipe *pipe, 
				/* allocate new frame */

				err = ia_css_frame_allocate_with_buffer_size(

					  &my_css.mipi_frames[port][i],

					  my_css.mipi_frame_size[port] * HIVE_ISP_DDR_WORD_BYTES,

					  false);

					  my_css.mipi_frame_size[port] * HIVE_ISP_DDR_WORD_BYTES);

				if (err) {

					for (j = 0; j < i; j++) {

						if (my_css.mipi_frames[port][j]) {