fix(windows): handle invalid package names during install
Fixes #4886. This patch includes 5 separate fixes for the various scenarios we encountered during package installation. 1. RunTools.pas: don't attempt to install TIPs if package is not also being installed. 2. Keyman.Setup.System.OnlineResourceCheck.pas, OnlineUpdateCheck.pas: handle online update check for packages with spaces or periods in the id (legacy packages only). 3. Keyman.Setup.System.InstallInfo.pas: Handle browsers renaming downloaded files with `(n)` and `[n]` patterns as well as the current ` (n)` pattern. 4. Keyman.Setup.System.InstallInfo.pas: Handle browsers renaming downloaded files with `_n` pattern. See code comments for details. 5. Keyman.Configuration.System.TIPMaintenance.pas: Avoid crashing if `kmshell -install-tips-for-packages` is passed an invalid package name. The crash is actually fixed in point 5 above, but the root causes are addressed in the other points.
parent
c225d65a
Please register or sign in to comment