* Consume NoDedupMemAnnotations in ResolveMemoryReference

The ComponentName being pointed to by the annotation no longer exists
after ReplaceSeqMems so we should consume the annotations

* Support renaming in ReplaceMemMacros

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>

Include Dead Modules in InstanceGraph.staticInstanceCount

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

Change InstanceGraph.staticInstanceCount to include modules with no
instances. Previously, these modules would just not be included.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Generates lint-clean Verilog for the case: x + -1

...where x is anything and 1 is any literal.

Master behavior:

  input x : SInt<8>
  output z : SInt<9>
  z <= add(x, SInt(-2))

generates

  assign z = $signed(x) + -8'sh2;

After this PR:

  assign z = $signed(x) - 8'sh2;

If the literal is the maximum possible literal, a special case is triggered to properly trim the resulting subtraction.

Input:

  input x : SInt<2>
  output z : SInt<3>
  z <= add(x, SInt(-2))

now generates (after this PR)

  assign z = $signed(x) - 3'sh2;

* Updated documentation

* Change ArrayBuffer to ListBuffer

* Change name to minNegValue

* Remove mutable public interfaces

Co-authored-by: Albert Magyar <albert.magyar@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Add reviewer checklist / update contributor checklist

* Update PULL_REQUEST_TEMPLATE.md

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>

Rename Modules Duplicated by EliminateTargetPaths

Add a test that EliminateTargetPaths properly duplicates an annotation
pointing at a ModuleTarget.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

Change the behavior of EliminateTargetPaths to generate ModuleTarget
renames when instances are duplicated. Previously, only InstanceTarget
renames would be generated.

In effect, annotations targeting a duplicated module when be
duplicated to point at the original and duplicated module.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

This adds a utility method, referringModule, to the Target object that
behaves like IsMember.pathlessTarget except that it returns the module
of an InstanceTarget. This is useful for situations where you want to
get at "the module" a target is pointing at, but you want behavior
to get an actual module from an instance.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

Better register const prop through speculative de-optimization

* Fixes #1240
* Add failing reg const prop test case from #1240

* Add constant prop to async regs

* Added another test of no reset value but constant assignment

* Clarify name of updateNodeMap

* Update constant assignment of async reset to not be inferred as a latch, works with donttouch

* Revert "Update constant assignment of async reset to not be inferred as a latch, works with donttouch"

This reverts commit 952bf38127cb32f814496a2b4b3bfb173d532728.

Change zero-width base case for Andr

* Fixes #1344

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* transform InlineBitExtractions

* InlineNotsTransform, InlineBitExtractionsTransform: inputForm/outputForm = UnknownForm

* clean up some minor redundancies from Adam review

* clarifications from Seldrige review