* Add support for readUnderWrite to SyncReadMem

* Add write collision behavior test to MemorySpec

* Update constant names

Add method asBool to Clock.

Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Remove redundancy code

* Remove blank line

* BitPat supports whitespace and underscores, presumably for human readability.
The BitPat.parse factory though did not remove these from the returned count.
This fixes that adds whitespace and underscores to the unit tests
This is an updated vesion of Chisel PR #1069

Co-authored-by: Chick Markley <chick@qrhino.com>
Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Provides Double and BigDecimal methods to  access literal values for FixedPoint and Interval

Co-authored-by: Chick Markley <chick@qrhino.com>

* Change when thunks return type to Any

Changes the type of the thunk for when and WhenContext methods from
call-by-name Unit to call-by-name Any. This prevents a
warning (-Ywarn-value-discard) where a when thunk is returning
something other than Unit that is then discarded, e.g., another
WhenContext.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

* Change switch thunk return to type to Any

Changes the type of switch thunks from call-by-name Unit to
call-by-name Any. This prevents a warning (-Ywarn-value-discard) when
the internals of a switch block return something other than Unit which
is then discarded.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

# Conflicts:
#	src/test/scala/chiselTests/IntervalSpec.scala

BitPat supports whitespace and underscores

Non-functional, must have been a typo

Co-authored-by: Albert Magyar <albert.magyar@gmail.com>
Co-authored-by: Chick Markley <chick@qrhino.com>

Fixed problem creating Interval literals with full ranges

Shortcut for .asUInt.asBool
Added test to show it works

- made .F and .I work for creating fixed point and interval lits from big decimal
- Added NumObject trait which provides new math conversions
- Made a Num object that extends NumObject
- Add this trait to FixedPoint and Interval for backward compatibility
- Removed code that is now in NumObject, keeping things DRY
- Add tests to FixedPointSpec to show lit conversion to double and big decimal
- Add tests to IntervalSpec to show lit conversion to double and big decimal
- Add tests to LiteralExtractorSpec to show general math conversions between BigInts with binary points and double and big decimal

The BitPat.parse factory though did not remove these from the returned count.
This fixes that adds whitespace and underscores to the unit tests
This is an updated vesion of Chisel PR #1069

This is just a band aid until an Aggregate `isLit()` method (for which work has begun) is implemented.

This removes a dead line where a WriteEmitted phase is constructed.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

- boundary testing was not taking binary point into account correctly
- add tests to show where things work and where they are supposed to fail

 Bug fixes to support code for Interval

  - getLowestPossibleValue
  - getHighestPossibleValue
  - getPossibleValues

- Fixed computation in getHighestPossibleValue, erroneously was using lower intead of upper

This reverts commit 85fe90d5.