Skip to content
GitLab
  1. Aug 21, 2020
  3. Aug 15, 2020
  5. Aug 14, 2020
  7. Aug 13, 2020
    • Jack Koenig's avatar
      Deprecate Module.io and BlackBox.io (#1550) · a66d2d15
      Jack Koenig authored 
      * Deprecate Module.io and BlackBox.io

This is a step toward unification of Module with MultiIOModule.
The future of BlackBox is a bit less clear, but its existing API can be
maintained without the io virtual method.

The trickier API to maintain is auto-IO wrapping for compatibility
Modules and BlackBoxes. This will probably require reflection to support
once the io virtual method is removed.

* Improve deprecation warning for io
      a66d2d15
    • Schuyler Eldridge's avatar
      Switch to HowToSerialize for Emission (#1405) · dbf4d546
      Schuyler Eldridge authored 
      

* Fix emit{Firrtl,Verilog} for CustomFileEmission

Change ChiselStage helper methods for emitting FIRRTL (emitFirrtl) and
Verilog (emitVerilog) to look for Circuit and Verilog annotations
instead of DeletedAnnotations. This is needed after migrating to the
CustomFileEmission mixin in FIRRTL where FIRRTL will no longer delete
emitter annotations.

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>

* Use CustomFileEmission for ChiselCircuitAnnotation

Removes the explicit chisel3.phases.Emitter and instead does emission
with a CustomFileEmission mixin to ChiselCircuitAnnotation. This then
prevents the need for passing around DeletedAnnotations. As a
consequence, I removed an unnecessary run of a second Converter in the
Driver.

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>

* Fix tests for use of CustomFileEmission trait

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>

* Fixes for newer CustomFileEmission API

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
      dbf4d546
  9. Aug 12, 2020
    • Justin Deters's avatar
      Bug fix for manipulating submodules in aspects (#1538) · e0c80517
      Justin Deters authored 
      * Fixed the aspect as parent bug in Data and MonoConnect

* refactored and cleaned up finding an aspect parent

* Added aspect fix to the BiConnect class

* added unit test for manipulating submodules via aspects

* Refactored to move determination of proper parent to Builder and made logic simpler in MonoConnect, Data, and BiConnect

* Removed unused function and provided Scaladoc for retrieveParent
      e0c80517
    • Jack Koenig's avatar
      Restore Counter.n API (#1546) · 3668532f
      Jack Koenig authored 
      Includes special case support for Counter(0) which has identical
behavior to Counter(1) except for the value of n.
      3668532f
  11. Aug 11, 2020
  13. Aug 07, 2020
  15. Aug 01, 2020
    • Albert Magyar's avatar
      Check whether signals escape their when scopes (#1518) · 5ecde24d
      Albert Magyar authored 
      * Include and check when scoping as part of reg/mem/wire/node bindings

* Allow outdated 'when' behavior of CHIRRTL memory ports with enables

* Extend cross-module / when-visibility checks to all data refs

* Fixes #1512
* Cannot be checked if outside a module context
* E.g. delayed evaluation of printf / assert args

* Add basic test cases for cross-module refs / signals escaping when scopes

* Remove illegal cross-module references from existing tests
      5ecde24d
  17. Jul 31, 2020
  19. Jul 30, 2020
  21. Jul 29, 2020
  23. Jul 26, 2020
  25. Jul 23, 2020
    • Tom Alcorn's avatar
      Basic model checking API (#1499) · 57c846b1
      Tom Alcorn authored 
      * Add `check(...)` affordance

* Add assert (renamed from check and fixed)

* Add verification statements

* Move formal to experimental.verification

* Make test use ChiselStage

`generateFirrtl` has been cut from Chisel

* Fix newly introduced style warnings

* Fix some old style warnings for good measure

* Revert "Fix some old style warnings for good measure"

This reverts commit 31d51726c2faa4c277230104bd469ff7ffefc890.

* Cut scalastyle comments

* Cut formal delimiter comments
      57c846b1
  27. Jul 22, 2020
  29. Jul 16, 2020
  31. Jul 14, 2020
  33. Jul 06, 2020
  35. Jul 01, 2020
  37. Jun 30, 2020
    • chick's avatar
      - A few final fixes after the rebase · 3694b092
      chick authored
      3694b092
    • chick's avatar
      This adds a mechanism for the unittests to be run with the TreadleBackend · 0a17d89f
      chick authored 
      This mechanism is not enabled and should not change the behavior of existing tests
A following PR will deliver a switch that will allow changing the backend.
The reasons for this PR
- Treadle tests run much faster, enabling quicker debugging and CI cycles
- This will help ensure fidelity of Treadle to the Verilator backend

A few tests are marked as verilator only due to black box limitations

Change treadle to a direct dependency

I tried to make it a test only dependency but the TesterDriver sits in src/main requiring that
regular compile have access to treadle

Oops, made treadle the default

A number of changes in response to @ducky64 review
- made backend check clearer and add error handling for multiple backends specified
- Fixed duplicate TargetDirAnnotation uses in Treadle backend
- Cleaned up BlackBox test formatting
- Undid unnecessary debugging changes from Counter
- Undid .gitignore change, that should be on another PR

A number of changes in response to @ducky64 review
- Undid debugging changes made to BitWiseOps
      0a17d89f
  39. Jun 24, 2020
  41. Jun 23, 2020