When prefixing with a data, eagly get local name (bp #1614) (#1615)
* When prefixing with a data, eagly get local name (#1614) Fixes #1606 Previously, the Data itself would be put on the prefix stack and its full name would be used as the prefix for subsequent names. This meant that prefixes would grow quadratically as the prefix is present both on the Data pushed to the stack, and on the stack itself. This is fixed by just using the "local" name of the Data being pushed on the stack. A related issue is deferring the name resolution. This led to unintuitive behavior when the name of a Data used as a prefix is overridden later (usually when the Data is a return value). The overriding name would show up in prefixes twice instead of once. It is much more intuitive to grab the name at the moment of the connection creating the prefix rather than deferring to later. Co-authored-by:mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 1b15dca5 ) * Waive MiMa failures on package private methods Co-authored-by:
Jack Koenig <koenig@sifive.com>
parent
d4372757
Please register or sign in to comment