Unverified Commit 600b040c authored by mergify[bot]'s avatar mergify[bot] Committed by GitHub
Browse files

Fix Double Elaboration Backportably (bp #1426) (#1431)



* Test that Elaborate only runs once

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit bfb5b354

)

* Expose ChiselStage's PhaseManager, rm extra wraps

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 23db44a4

)

* Fix double elaboration

Remove the requirement that FirrtlStage runs elaboration (this should
be implicit) and remove the unneeded invalidation of elaboration by
the Emitter. Due to Convert currently NOT invalidating Elaborate (when
it should), add an optionalPrerequisiteOf to ensure that the Emitter
runs before the Convert phase.

Co-authored-by: default avatarDavid Biancolin <david.biancolin@gmail.com>
Co-authored-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 5e2ca44a

)

Co-authored-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
parent 5972b370
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment