Unverified Commit 18ce22ba authored by mergify[bot]'s avatar mergify[bot] Committed by GitHub
Browse files

Fix aop.Select behavior for CloneModuleAsRecord (backport #1993) (#1994)

* Restore aop.Select behavior for CloneModuleAsRecord

(cherry picked from commit 0531cb53)

* Change behavior of aop.Select to not include CloneModuleAsRecord

Previously, CloneModuleAsRecord clones would result in the same
BaseModule object coming up multiple times when using APIs like
.instances, .collectDeep, and .getDeep. This was not the intended
behavior and can lead to very subtle bugs.

(cherry picked from commit 25a84b56

)

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
parent 081874e5
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment