Unverified Commit 00042475 authored by mergify[bot]'s avatar mergify[bot] Committed by GitHub
Browse files

Fix chisel3 <> for compatibility Bundles (Take 3) (#2093) (#2106)

Previous incomplete fixes in #2023 and #2031.

The legality of a FIRRTL connection is determined by type and flow.
Chisel does not have access to true flow information. Previous fix
attempts tried to use ActualDirection as a stand-in for flow, but it is
incorrect in many cases. This new approach checks the flows of the
lvalue and rvalues in the connect and flips the connection if either
the lvalue cannot be a sink or the rvalue cannot be a source.

(cherry picked from commit 7fb2c1eb

)

Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
parent 18e6077f
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment