https://bugs.eclipse.org/bugs/show_bug.cgi?id=565671

Closes #1748. Closes #117. Thanks to Sigmund Vik.

This applies on Linux, FreeBSD, NetBSD, and OpenBSD.

Closes #1777. Thanks to ABuch19.

Merge branch 'improve-client-store' of git://github.com/dbeinder/mosquitto into dbeinder-improve-client-store

keep v5 client read test to test for backwards compatability
adds username="usrname" and listener_port=1883 for v6 tests

Signed-off-by: david-beinder <david.beinder@mce.li>

Signed-off-by: david-beinder <david.beinder@mce.li>

Closes #1773. Closes #1774. Thanks to Yingpei Zeng.

This is to avoid a long delay when shutting down the broker.

Closes #1735. Thanks to Colin Law.

Rather than the generic "socket error".

Related to #1765.

Closes #1689. Closes #1741. Thanks to Brett M. Gordon and tt92.

Closes #1718. Thanks to Luca Casonato.

This was always returning success when the client was not connected.

Closes #1725. Thanks to BOTorioN.

Closes #1726. Thanks to nduhme.

This occurred incorrectly when clean start was set to true.

Closes #1729. Thanks to Andreyooo.

Coverity Scan 1430456.

This wasn't a problem because this error caused the program to
exit, so there was no real resource leak.

Coverity Scan 1430457.

Coverity Scan 1430458.

Closes #1749. Thanks to cieslarchristian.

This happens before starting the broker.

Also don't quit with an error if opening the log file isn't possible.

Closes #821.

Closes #1740. Thanks to OkenKhuman.

From the FormatMessage() Win32 API documentation: "The lpBuffer
parameter is a pointer to an LPTSTR; you must cast the pointer
to an LPTSTR (for example, (LPTSTR)&lpBuffer)."

https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-formatmessage#parameters



This commit fixes warnings like these:
warning C4047: 'function': 'LPSTR' differs in levels of indirection from 'char **'
warning C4024: 'FormatMessageA': different types for formal and actual parameter 5

Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>

This fixes Visual Studio compiler warnings like this one:
"warning C4003: not enough arguments for function-like
macro invocation 'G_MSGS_DROPPED_INC'"

Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>

Before this commit there was no good way to detect that the
Mosquitto broker was done with its startup phase on systems
without systemd.

On such systems it was tricky to e.g. start the broker from
a test where ports are dynamically assigned and one have to
deal with potential port conflicts.  Without a way to know
that the broker is done with its startup phase, there was no
way to know if the broker was able to acquire the port (for
both IPv4 and IPv6) without waiting for some unknown period
of time (when many tests are run in parallel a single process
might be starved for resources).

With this new broker ready message it is easy for the parent
process to monitor the broker output and figure out when the
port was successfully acquired.

Signed-off-by: Sigmund Vik <sigmund_vik@yahoo.com>

Close #1730. Thanks to John Laird.

otherwise in6_addr, AF_INET and AF_INET6 end up being undefined

Signed-off-by: Jasper Lievisse Adriaanse <jasper@humppa.nl>

fixes "ld: error: unable to find library -ldl"

Signed-off-by: Jasper Lievisse Adriaanse <jasper@humppa.nl>

Fix typos

Signed-off-by: HowJMay <vulxj0j8j8@gmail.com>

Port 9001 is used by Intel drivers on Windows, so some users are
suddenly seeing a problem.

Issue #1580.

Closes #1713. Thanks to whnr.

Signed-off-by: matt <swineherd92@gmail.com>