Unverified Commit 30a87a7f authored by Shubham Dhama's avatar Shubham Dhama Committed by GitHub
Browse files

Fix escaping of identifiers while transforming for wal2json plugin. (#595)



* add quotes identifiers

* test changes

* Fix escaping of identifiers while transforming for wal2json plugin.

wal2json doesn't escape identifiers as test_decoding do. To fix this issue
we are using PQescapeIdentifier function. Even though this function doesn't
require PGconn to be connected, but creating an empty PGconn object was
unfeasible. Some fields of PGconn that are required by new versions of
libpq for PQescapeIdentifier are not available in older PGconn. So decided
to do this the right way, but creating PGconn with an actual server
connection. It turned out more simpler than managing a dummy PGconn object.

* Fix review comments.

* Fix style.

---------

Co-authored-by: default avatarVaibhaveS <vaibhavedavey@gmail.com>
parent d7a1ea0a
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment