zlib: Fix arg error checking

It is wrong to call Jim_WrongNumArgs() with argc == 0.
Instead -1 should be returned from the subcmd function to display the standard error message.

Add a --maintainer check for this condition in Jim_WrongNumArgs() and fix the zlib unit tests.

Signed-off-by: Steve Bennett <steveb@workware.net.au>

1 files changed, 5 insertions, 1 deletions

diff --git a/jim.c b/jim.c
index d7d5f0e..00c6c0c 100644
--- a/jim.c
+++ b/jim.c
@@ -11363,7 +11363,11 @@ int Jim_SubstObj(Jim_Interp *interp, Jim_Obj *substObjPtr, Jim_Obj **resObjPtrPt
 void Jim_WrongNumArgs(Jim_Interp *interp, int argc, Jim_Obj *const *argv, const char *msg)
 {
     Jim_Obj *objPtr;
-    Jim_Obj *listObjPtr = Jim_NewListObj(interp, argv, argc);
+    Jim_Obj *listObjPtr;
+
+    JimPanic((argc == 0, "Jim_WrongNumArgs() called with argc=0"));
+
+    listObjPtr = Jim_NewListObj(interp, argv, argc);
 
     if (*msg) {
         Jim_ListAppendElement(interp, listObjPtr, Jim_NewStringObj(interp, msg, -1));