From cca64798f8f01f2f06dbc020113cf9497b56f68b Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Mon, 19 Dec 2022 23:37:07 +0100 Subject: target: rewrite command 'was_examined' as COMMAND_HANDLER Check for empty command line, add the mandatory 'usage' field. Change-Id: I3f59448458fe01268bf5f4293aea5adcbd6d8279 Signed-off-by: Antonio Borneo Reviewed-on: https://review.openocd.org/c/openocd/+/7505 Tested-by: jenkins --- src/target/target.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/target/target.c b/src/target/target.c index da9cab9..264b85f 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -5716,14 +5716,16 @@ static int jim_target_examine(Jim_Interp *interp, int argc, Jim_Obj *const *argv return JIM_OK; } -static int jim_target_was_examined(Jim_Interp *interp, int argc, Jim_Obj * const *argv) +COMMAND_HANDLER(handle_target_was_examined) { - struct command_context *cmd_ctx = current_command_context(interp); - assert(cmd_ctx); - struct target *target = get_current_target(cmd_ctx); + if (CMD_ARGC != 0) + return ERROR_COMMAND_SYNTAX_ERROR; - Jim_SetResultBool(interp, target_was_examined(target)); - return JIM_OK; + struct target *target = get_current_target(CMD_CTX); + + command_print(CMD, "%d", target_was_examined(target) ? 1 : 0); + + return ERROR_OK; } static int jim_target_examine_deferred(Jim_Interp *interp, int argc, Jim_Obj * const *argv) @@ -6078,8 +6080,9 @@ static const struct command_registration target_instance_command_handlers[] = { { .name = "was_examined", .mode = COMMAND_EXEC, - .jim_handler = jim_target_was_examined, + .handler = handle_target_was_examined, .help = "used internally for reset processing", + .usage = "", }, { .name = "examine_deferred", -- cgit v1.1