From 3934483429b77525f25922787933fb7ee3e73a0f Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Mon, 17 Aug 2020 09:58:58 +0200 Subject: target: avoid checking for non NULL pointer to free it The function free() can be called with a NULL pointer as argument, no need to check the argument before. If the pointer is NULL, no operation is performed by free(). Remove the occurrences of pattern: if (ptr) free(ptr); In target/openrisc/jsp_server.c, an error is logged if the ptr was already NULL. This cannot happen since the pointer was already referenced few lines before and openocd would have been already SIGSEGV in that case, so remove the log. Change-Id: I290a32e6d4deab167676af4ddc83523c830ae49e Signed-off-by: Antonio Borneo Reviewed-on: http://openocd.zylin.com/5809 Tested-by: jenkins --- src/target/openrisc/jsp_server.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'src/target/openrisc/jsp_server.c') diff --git a/src/target/openrisc/jsp_server.c b/src/target/openrisc/jsp_server.c index f28815d..1d05944 100644 --- a/src/target/openrisc/jsp_server.c +++ b/src/target/openrisc/jsp_server.c @@ -190,12 +190,8 @@ static int jsp_connection_closed(struct connection *connection) if (ERROR_OK != retval) return retval; - if (connection->priv) { - free(connection->priv); - connection->priv = NULL; - } else - LOG_ERROR("BUG: connection->priv == NULL"); - + free(connection->priv); + connection->priv = NULL; return ERROR_OK; } -- cgit v1.1