From 69ff7354d9c9accf09374772310098f1f00e8ccb Mon Sep 17 00:00:00 2001 From: Marc Schink Date: Sun, 22 May 2016 20:35:34 +0200 Subject: helper: Code cleanup for hexify() Simplify hexify() and do not longer use 0 as special case for the parameter 'count' to determine the string length of the binary input. Instead, use strlen() outside of the function if needed. Additionally, fix the return value and return the length of the converted string. The old function always returned 2 * count. Also, use more appropriate data types for the function parameters and add a small documentation. Change-Id: I133a8ab786b8f7c1296afcaf9c0a0b43881e5112 Signed-off-by: Marc Schink Reviewed-on: http://openocd.zylin.com/3793 Tested-by: jenkins Reviewed-by: Tomas Vanek --- src/rtos/linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/rtos/linux.c') diff --git a/src/rtos/linux.c b/src/rtos/linux.c index 31d6618..e5a4efc 100644 --- a/src/rtos/linux.c +++ b/src/rtos/linux.c @@ -1229,7 +1229,8 @@ int linux_thread_extra_info(struct target *target, sprintf(tmp_str_ptr, "%s", name); sprintf(tmp_str_ptr, "%s", temp->name); char *hex_str = calloc(1, strlen(tmp_str) * 2 + 1); - int pkt_len = hexify(hex_str, tmp_str, 0, strlen(tmp_str) * 2 + 1); + size_t pkt_len = hexify(hex_str, (const uint8_t *)tmp_str, + strlen(tmp_str), strlen(tmp_str) * 2 + 1); gdb_put_packet(connection, hex_str, pkt_len); free(hex_str); free(tmp_str); -- cgit v1.1