From 3a4f445bd92101d3daee3715178d3fbff3b7b029 Mon Sep 17 00:00:00 2001 From: Paul Fertser Date: Tue, 2 May 2023 15:15:21 +0300 Subject: jtag: tcl: show error message when attempting manual "drscan" on a bypassed tap To perform any meaningful manipulations with DR the corresponding IR should be set to a relevant instruction, not BYPASS, so warn the user accordingly. Signed-off-by: Paul Fertser Change-Id: I42580ecd75ae824a4145f6f17f0df9bcf825b50f Reviewed-on: https://review.openocd.org/c/openocd/+/7654 Reviewed-by: Antonio Borneo Tested-by: jenkins --- src/jtag/tcl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c index 3954390..934b603 100644 --- a/src/jtag/tcl.c +++ b/src/jtag/tcl.c @@ -116,6 +116,11 @@ COMMAND_HANDLER(handle_jtag_command_drscan) return ERROR_COMMAND_ARGUMENT_INVALID; } + if (tap->bypass) { + command_print(CMD, "Can't execute as the selected tap is in BYPASS"); + return ERROR_FAIL; + } + tap_state_t endstate = TAP_IDLE; if (CMD_ARGC > 3 && !strcmp("-endstate", CMD_ARGV[CMD_ARGC - 2])) { const char *state_name = CMD_ARGV[CMD_ARGC - 1]; -- cgit v1.1