diff options
| author | Spencer Oliver <spen@spen-soft.co.uk> | 2013-01-28 11:45:51 +0000 |
|---|---|---|
| committer | Øyvind Harboe <oyvindharboe@gmail.com> | 2013-01-31 14:50:24 +0000 |
| commit | bf3f35092ea96b33ceda33d497ec04514e94cb00 (patch) | |
| tree | 5acbf84f4bcf2f348ee4571e354626b72b9a5d5a /src | |
| parent | 4a5c9a4965eff5aa678ccc7d1f50da714238b77a (diff) | |
| download | riscv-openocd-bf3f35092ea96b33ceda33d497ec04514e94cb00.zip riscv-openocd-bf3f35092ea96b33ceda33d497ec04514e94cb00.tar.gz riscv-openocd-bf3f35092ea96b33ceda33d497ec04514e94cb00.tar.bz2 | |
helper: hexify correctly handle signed chars
The current implementation of hexify was not correctly handling signed chars.
This function is currently used by the ti-icdi driver and as such was causing
random write issues.
As a note perhaps a better long term fix would be to change to using uint8_t
buffers rather than char. This will require changes to the ti-icdi driver
aswell.
Change-Id: I572e69ff2b99227a7d412de056458c0393794b03
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/1124
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/helper/binarybuffer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/helper/binarybuffer.c b/src/helper/binarybuffer.c index a90ec7b..b3e4491 100644 --- a/src/helper/binarybuffer.c +++ b/src/helper/binarybuffer.c @@ -393,7 +393,7 @@ int hexify(char *hex, const char *bin, int count, int out_maxlen) count = strlen(bin); for (i = 0; i < count; i++) - cmd_len += snprintf(hex + cmd_len, out_maxlen - cmd_len, "%02x", bin[i]); + cmd_len += snprintf(hex + cmd_len, out_maxlen - cmd_len, "%02x", bin[i] & 0xff); return cmd_len; } |