diff options
| author | Andreas Fritiofson <andreas.fritiofson@gmail.com> | 2013-09-30 23:33:59 +0200 |
|---|---|---|
| committer | Spencer Oliver <spen@spen-soft.co.uk> | 2013-10-31 20:45:55 +0000 |
| commit | 4f6f065201e908497f087769dcdff1728466df4e (patch) | |
| tree | b00e0022f4699c8d5baa394433a213850dcbb8c2 /src | |
| parent | 484dbcc3027d030c6200632262c24615f8eb8514 (diff) | |
| download | riscv-openocd-4f6f065201e908497f087769dcdff1728466df4e.zip riscv-openocd-4f6f065201e908497f087769dcdff1728466df4e.tar.gz riscv-openocd-4f6f065201e908497f087769dcdff1728466df4e.tar.bz2 | |
smp: Fix byte order bug
Found by grepping for pointer casts.
Also rewrite to reduce scope and allocate the few bytes needed on stack
instead of on heap.
Change-Id: Ia2a369fb612e807b981ee60ebcfd9c09c2fbdf4c
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1779
Tested-by: jenkins
Reviewed-by: Mathias Küster <kesmtp@freenet.de>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Diffstat (limited to 'src')
| -rw-r--r-- | src/target/smp.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/src/target/smp.c b/src/target/smp.c index 39a9533..d14ceba 100644 --- a/src/target/smp.c +++ b/src/target/smp.c @@ -59,18 +59,16 @@ int gdb_read_smp_packet(struct connection *connection, char *packet, int packet_size) { struct target *target = get_target_from_connection(connection); - uint32_t len = sizeof(int32_t); - uint8_t *buffer; - char *hex_buffer; int retval = ERROR_OK; if (target->smp) { if (strncmp(packet, "jc", 2) == 0) { - hex_buffer = malloc(len * 2 + 1); - buffer = (uint8_t *)&target->gdb_service->core[0]; - int pkt_len = hexify(hex_buffer, (char *)buffer, len, len * 2 + 1); + const uint32_t len = sizeof(target->gdb_service->core[0]); + char hex_buffer[len * 2 + 1]; + char buffer[len]; + buf_set_u32(buffer, 0, len * 8, target->gdb_service->core[0]); + int pkt_len = hexify(hex_buffer, buffer, sizeof(buffer), sizeof(hex_buffer)); retval = gdb_put_packet(connection, hex_buffer, pkt_len); - free(hex_buffer); } } else retval = gdb_put_packet(connection, "E01", 3); |