diff options
| author | Tomas Vanek <vanekt@fbl.cz> | 2019-12-20 23:56:08 +0100 |
|---|---|---|
| committer | Tomas Vanek <vanekt@fbl.cz> | 2020-03-07 15:30:05 +0000 |
| commit | a2e822834df52efef5e1bbcb91a6eb1afbf102db (patch) | |
| tree | 0e5caf3d1daa7dfeb6cabc7f3163d6dd5bbc73f9 /src/target/etm.c | |
| parent | 4e981bc27c36e696dc8ace3ab4bab534564770c1 (diff) | |
| download | riscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.zip riscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.tar.gz riscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.tar.bz2 | |
helper/binarybuffer: fix clang static analyzer warnings
Writing bits to an uninitialized buffer generated false warnings.
Zero buffers before setting them by buf_set_u32|64()
(do it only if bit-by-bit copy loop is used,
zeroed buffer is not necessary if a fast path write is used)
Change-Id: I2f7f8ddb45b0cbd08d3e249534fc51f4b5cc6694
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/5383
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Diffstat (limited to 'src/target/etm.c')
| -rw-r--r-- | src/target/etm.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/target/etm.c b/src/target/etm.c index d1cfe61..5218a9e 100644 --- a/src/target/etm.c +++ b/src/target/etm.c @@ -533,7 +533,7 @@ static int etm_read_reg_w_check(struct reg *reg, fields[0].check_mask = NULL; fields[1].num_bits = 7; - uint8_t temp1; + uint8_t temp1 = 0; fields[1].out_value = &temp1; buf_set_u32(&temp1, 0, 7, reg_addr); fields[1].in_value = NULL; @@ -541,7 +541,7 @@ static int etm_read_reg_w_check(struct reg *reg, fields[1].check_mask = NULL; fields[2].num_bits = 1; - uint8_t temp2; + uint8_t temp2 = 0; fields[2].out_value = &temp2; buf_set_u32(&temp2, 0, 1, 0); fields[2].in_value = NULL; @@ -620,13 +620,13 @@ static int etm_write_reg(struct reg *reg, uint32_t value) fields[0].in_value = NULL; fields[1].num_bits = 7; - uint8_t tmp2; + uint8_t tmp2 = 0; fields[1].out_value = &tmp2; buf_set_u32(&tmp2, 0, 7, reg_addr); fields[1].in_value = NULL; fields[2].num_bits = 1; - uint8_t tmp3; + uint8_t tmp3 = 0; fields[2].out_value = &tmp3; buf_set_u32(&tmp3, 0, 1, 1); fields[2].in_value = NULL; |