diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2022-09-19 11:36:06 +0200 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2022-09-23 21:22:09 +0000 |
| commit | 8683526af7a9ca23115d26deb5b4835cd6be05d8 (patch) | |
| tree | e4c9f0210458730905c031323ec9c321c1883ee1 /src/target/dsp563xx.c | |
| parent | cde944fd8b9cd5eb67617aa3b68dc13eb49b1d10 (diff) | |
| download | riscv-openocd-8683526af7a9ca23115d26deb5b4835cd6be05d8.zip riscv-openocd-8683526af7a9ca23115d26deb5b4835cd6be05d8.tar.gz riscv-openocd-8683526af7a9ca23115d26deb5b4835cd6be05d8.tar.bz2 | |
target/dsp563xx: fix scan-build warning
Scan-build triggers a warning:
Unix API: Allocator sizeof operand mismatch
dsp563xx.c:2143 Result of 'calloc' is converted to a pointer
of type 'uint8_t', which is incompatible with sizeof
operand type 'uint32_t'
It's a false positive because calloc() is properly used in this
case, as the uint8_t array is used in blocks of 4 elements to read
or write uint32_t values.
Either
calloc(sizeof(uint32_t), count);
and
malloc(count * sizeof(uint32_t));
keep triggering the same warning.
Drop the warning by using the constant '4' as size of uint32_t, as
already used few lines below.
Change-Id: I5bb1ece177774eefdc5d9cd049338f8f2be87cd7
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7203
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Diffstat (limited to 'src/target/dsp563xx.c')
| -rw-r--r-- | src/target/dsp563xx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/target/dsp563xx.c b/src/target/dsp563xx.c index 3702cfb..36ee853 100644 --- a/src/target/dsp563xx.c +++ b/src/target/dsp563xx.c @@ -2140,7 +2140,7 @@ COMMAND_HANDLER(dsp563xx_mem_command) COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], count); } - buffer = calloc(count, sizeof(uint32_t)); + buffer = calloc(count, 4); if (read_mem == 1) { err = dsp563xx_read_memory(target, mem_type, address, sizeof(uint32_t), |