aboutsummaryrefslogtreecommitdiff
path: root/src/jtag/tcl.c
diff options
context:
space:
mode:
authorTomas Vanek <vanekt@fbl.cz>2019-12-20 23:56:08 +0100
committerTomas Vanek <vanekt@fbl.cz>2020-03-07 15:30:05 +0000
commita2e822834df52efef5e1bbcb91a6eb1afbf102db (patch)
tree0e5caf3d1daa7dfeb6cabc7f3163d6dd5bbc73f9 /src/jtag/tcl.c
parent4e981bc27c36e696dc8ace3ab4bab534564770c1 (diff)
downloadriscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.zip
riscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.tar.gz
riscv-openocd-a2e822834df52efef5e1bbcb91a6eb1afbf102db.tar.bz2
helper/binarybuffer: fix clang static analyzer warnings
Writing bits to an uninitialized buffer generated false warnings. Zero buffers before setting them by buf_set_u32|64() (do it only if bit-by-bit copy loop is used, zeroed buffer is not necessary if a fast path write is used) Change-Id: I2f7f8ddb45b0cbd08d3e249534fc51f4b5cc6694 Signed-off-by: Tomas Vanek <vanekt@fbl.cz> Reviewed-on: http://openocd.zylin.com/5383 Tested-by: jenkins Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Diffstat (limited to 'src/jtag/tcl.c')
-rw-r--r--src/jtag/tcl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c
index ba0cb1d..734b9c1 100644
--- a/src/jtag/tcl.c
+++ b/src/jtag/tcl.c
@@ -1131,7 +1131,7 @@ COMMAND_HANDLER(handle_irscan_command)
}
int field_size = tap->ir_length;
fields[i].num_bits = field_size;
- uint8_t *v = malloc(DIV_ROUND_UP(field_size, 8));
+ uint8_t *v = calloc(1, DIV_ROUND_UP(field_size, 8));
uint64_t value;
retval = parse_u64(CMD_ARGV[i * 2 + 1], &value);